Temporarily disabled jsArrowFuncArgs with parens #380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -227,7 +227,7 @@ syntax match jsFuncArgDestructuring contained /\({\|}\|=\|:\|(\|)\)/ extend | |||
| " Matches a single keyword argument with no parens | |||
| syntax match jsArrowFuncArgs /\(\k\)\+\s*\(=>\)\@=/ skipwhite contains=jsFuncArgs nextgroup=jsArrowFunction | |||
| " Matches a series of arguments surrounded in parens | |||
| syntax match jsArrowFuncArgs /(\%(.\)*)\s*\(=>\)\@=/ skipempty skipwhite contains=jsFuncArgs nextgroup=jsArrowFunction | |||
| " syntax match jsArrowFuncArgs /(\%(.\)*)\s*\(=>\)\@=/ skipempty skipwhite contains=jsFuncArgs nextgroup=jsArrowFunction | |||
There was a problem hiding this comment.
We reference jsArrowFuncArgs in other places. Will this cause problems since it is no longer defined?
There was a problem hiding this comment.
There's a jsArrowFuncArgs right above it, the single keyword detection is very safe and I am leaving that in, so it shouldn't matter. I am keeping this as a comment for easy reference for to fix.
amadeus
force-pushed
the
temporary-fix-for-arrow-func-args
branch
from
c8f0936 to
3a4d2ac
Compare
|
LGTM |
This is until we can figure out how to properly match all the crazy use cases.
amadeus
force-pushed
the
temporary-fix-for-arrow-func-args
branch
from
3a4d2ac to
992b76d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is until we can figure out how to properly match all the crazy use
cases.
This should at least make issues #364 and #378 not appear as errors.